Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Italian locale #1047

Merged
merged 5 commits into from Feb 13, 2020
Merged

Italian locale #1047

merged 5 commits into from Feb 13, 2020

Conversation

egueli
Copy link
Contributor

@egueli egueli commented Feb 11, 2020

Here are the library strings, translated in Italian.

I lack lots of context and I know little about AC technologies, so some translations may be off. In particular, the composed strings like D_STR_EYEAUTO make totally no sense to me (that one translates to Occhio Auto, literally Auto Eye).

It would be nice to have some context (i.e. where/how the original string is used), but I guess that's a common problem in every translation.

I tried to keep strings that look trademarked (like 6th Sense or Zone Follow) as they are.

egueli and others added 2 commits February 11, 2020 09:15
src/locale/it-IT.h:171:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
@crankyoldgit crankyoldgit self-requested a review February 11, 2020 11:48
#define D_STR_OFF "Spento"
#define D_STR_MODE "Modalità"
#define D_STR_TOGGLE "Alterna"
#define D_STR_TURBO "Turbo"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, where the word/spelling doesn't change, you don't need to include it.
I'll remove anything obvious that doesn't change.

Remove words that are the same as English (en-AU) and are not required due to use later.
Copy link
Owner

@crankyoldgit crankyoldgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed what I think are the redundant entries. Everything except D_STR_SLEEP look good to me (like I can tell anyway ;-)

Fix that one and I think we are good to merge.

src/locale/it-IT.h Outdated Show resolved Hide resolved
Copy link
Owner

@crankyoldgit crankyoldgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crankyoldgit crankyoldgit merged commit 3711d57 into crankyoldgit:master Feb 13, 2020
crankyoldgit added a commit that referenced this pull request Feb 26, 2020
_v2.7.4 (20200226)_

**[Bug Fixes]**
- IRMQTTServer: Fix bug when receiving an IR A/C message and not re-transmitting it. (#1035, #1038)
- Coolix: `setRaw()` doesn't update power state. (#1040, #1041)

**[Features]**
- Electra: Add improved feature support. (#1033, #1051)
- Add support for Epson protocol. (#1034, #1050)
- Add options to `decode()` to aid detection. Improve NEC detection. (#1042, #1046)
- SamsungAc: Add support for Light & Ion (VirusDoctor). (#1045, #1048, #1049)
- Add Italian (it-IT) locale/language support. (#1047) (kudos @egueli)
- gc_decode: Add repeat support for pronto codes. (#1034, #1043)

**[Misc]**
- Update supported SamsungAc devices (#1045)
- Coolix: Subtle protocol timing adjustments (#1036, #1037)
- Add supported Electra device model info (#1033)
@crankyoldgit crankyoldgit mentioned this pull request Feb 26, 2020
crankyoldgit added a commit that referenced this pull request Feb 26, 2020
_v2.7.4 (20200226)_

**[Bug Fixes]**
- IRMQTTServer: Fix bug when receiving an IR A/C message and not re-transmitting it. (#1035, #1038)
- Coolix: `setRaw()` doesn't update power state. (#1040, #1041)

**[Features]**
- Electra: Add improved feature support. (#1033, #1051)
- Add support for Epson protocol. (#1034, #1050)
- Add options to `decode()` to aid detection. Improve NEC detection. (#1042, #1046)
- SamsungAc: Add support for Light & Ion (VirusDoctor). (#1045, #1048, #1049)
- Add Italian (it-IT) locale/language support. (#1047) (kudos @egueli)
- gc_decode: Add repeat support for pronto codes. (#1034, #1043)

**[Misc]**
- Update supported SamsungAc devices (#1045)
- Coolix: Subtle protocol timing adjustments (#1036, #1037)
- Add supported Electra device model info (#1033)
@crankyoldgit
Copy link
Owner

The changes mentioned above have been included in the latest IRremoteESP8266 v2.7.4 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants