Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pushing all docker tags on build --push #110

Merged
merged 2 commits into from Dec 13, 2023
Merged

fix: pushing all docker tags on build --push #110

merged 2 commits into from Dec 13, 2023

Conversation

miki725
Copy link
Contributor

@miki725 miki725 commented Dec 12, 2023

Issue

chalk docker build -t foo -t bar --push .

this would only push foo tag and not push bar tag

Description

When specifying multiple tags during docker build, all tags are pushed to the registry when --push flag is used.

Testing

➜ make tests args="test_docker.py::test_multiple_tags --logs"

```
chalk docker build -t foo -t bar --push .
```

chalk should push all provided tags, not just first one
@miki725 miki725 requested a review from viega as a code owner December 12, 2023 18:33
@miki725 miki725 merged commit 4e8ad81 into main Dec 13, 2023
2 checks passed
@miki725 miki725 deleted the ms/tags branch December 13, 2023 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants