Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cmd_version): fix typo of Build Date #148

Merged
merged 1 commit into from Jan 24, 2024
Merged

Conversation

ee7
Copy link
Contributor

@ee7 ee7 commented Jan 24, 2024

Description

Trivial PR: change "Build Data" to "Build Date" in the output of the version command. All the other rows are "data" too, so I guess it's supposed to say Date.

With the most recent chalk release (chalk 0.3.1, 2024-01-23):

$ chalk version

 ┌┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┬┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┐
 ┊ Chalk Version  ┊ 0.3.1                                       ┊
 ┊ Commit ID      ┊ 646e9886f2ca74bc0c8b5ebd94d68f7b01d7d0d2    ┊
 ┊ Build OS       ┊ linux                                       ┊
 ┊ Build CPU      ┊ amd64                                       ┊
 ┊ Build Data     ┊ 2024-01-23                                  ┊
 ┊ Build Time     ┊ 17:00:15                                    ┊
 └┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┴┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┘

Testing

None.

The tests don't currently check the exact output of this command, given that this was the only occurrence of "Build Data" in the codebase. But given the recent rendering bug on some platforms, maybe a test for that would be worthwhile adding later.

Fix a typo that appeared in the output of the version command.

With the most recent chalk release (chalk 0.3.1, 2024-01-23):

    $ chalk version

     ┌┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┬┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┐
     ┊ Chalk Version  ┊ 0.3.1                                       ┊
     ┊ Commit ID      ┊ 646e988    ┊
     ┊ Build OS       ┊ linux                                       ┊
     ┊ Build CPU      ┊ amd64                                       ┊
     ┊ Build Data     ┊ 2024-01-23                                  ┊
     ┊ Build Time     ┊ 17:00:15                                    ┊
     └┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┴┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┘
@ee7 ee7 requested a review from viega as a code owner January 24, 2024 10:24
Copy link
Contributor

@viega viega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whaps himself for not proofreading better

@ee7 ee7 merged commit f740ac6 into main Jan 24, 2024
2 checks passed
@ee7 ee7 deleted the ee7/cmd-version-fix-typo branch January 24, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants