fix(ioconfig): disable color when TERM is dumb #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chalk output previously contained color when the `TERM` environment
variable had the value `dumb`. Disable color for that situation.
Chalk already correctly disabled color when:
- The user passes `--no-color` [1], For example:
`chalk version --no-color`
- The `NO_COLOR` environment variable is set. For example:
`NO_COLOR=1 chalk version`
- stdout is not a tty. For example:
`chalk version > /tmp/version.txt`
Closes: #162
[1] See also https://no-color.org/
miki725
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#162
Description
Chalk output previously contained color when the
TERMenvironment variable had the valuedumb. Disable color for that situation.Chalk already correctly disabled color when:
The user passes
--no-color(see also https://no-color.org/). For example:chalk version --no-colorThe
NO_COLORenvironment variable is set. For example:NO_COLOR=1 chalk versionstdout is not a tty. For example:
chalk version > /tmp/version.txtFixes: #162
Testing
Run e.g.
TERM=dumb chalk versionand observe the lack of color.We don't currently have a test for
TERM=dumborNO_COLOR=1.