Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: docker login breaks when docker is chalk binary #209

Merged
merged 3 commits into from Feb 19, 2024
Merged

fix: docker login breaks when docker is chalk binary #209

merged 3 commits into from Feb 19, 2024

Conversation

miki725
Copy link
Contributor

@miki725 miki725 commented Feb 19, 2024 •
edited

Issue

fixes #194

Description

fixed was in crashappsec/nimutils#46

Testing

echo foo | ./chalk docker login --password-stdin --username=bar

@miki725 miki725 requested a review from ee7 February 19, 2024 17:37
@miki725 miki725 requested a review from viega as a code owner February 19, 2024 17:37
@miki725 miki725 changed the title build: recompiling chalk in nimble c changes fix: docker login breaks when docker is chalk binary Feb 19, 2024
@miki725 miki725 merged commit 72a92cc into main Feb 19, 2024
2 checks passed
@miki725 miki725 deleted the ms/pty branch February 19, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viega viega viega approved these changes

@ee7 ee7 ee7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docker login breaks when docker is chalk binary
3 participants
@miki725 @viega @ee7