fix: segfault in chalk backup service #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the safeRequest refactor now creates and closes the client which wasnt correctly refactored and wasnt caught. there are no tests for this and its not easy to add them as it will require adding JWTs in the mix. upcoming refactor for signing keys will refactor this and will make it easier to test this
ee7
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
backup service bug in attestion.nim causes segfault
Description
the safeRequest refactor now creates and closes the client which wasnt correctly refactored and wasnt caught.
there are no tests for this and its not easy to add them as it will require adding JWTs in the mix. upcoming refactor for signing keys will refactor this and will make it easier to test this
Testing