fix(tools): Load tool configs for docker #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e importantly, the config load wasn't running for all commands, and the test for which commands to load it on was wrong; docker wasn't on the list. I removed the test, because this is going to get cached anyway before too long.
command execution, to test those.
indecisivedragon
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #82
Description
Internal tool configs now always load (they were not loading for all commands). But this is the right choice since the entire startup config is going to end up cached soon anyway.
I also removed the
runs_oncenotion. In the case of Docker, tools in the host bass will see '.'; the second time it will see the container name. Might want to provide access to context info in the future.Testing
Check at the end of a docker build run to see that the tools loaded.