Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update sigs for csgo velocity overlay #43

Closed
wants to merge 1 commit into from

Conversation

rtldg
Copy link

@rtldg rtldg commented Jul 15, 2021

This updates the CSGO sigs to GetSpectatorTarget and UTIL_PlayerByIndex.

Also, I noticed that config-001-player-abs-velocity-offset (37) seemed to result in the player being show as 0 velocity when in thirdperson mode spectating someone, so I swapped it to 69 (nice) which should be m_vecVelocity. Since the CSS offset is really close at 61, I think it actually mean that CSS is using m_vecVelocity too instead of m_vecAbsVelocity.

Since this was mostly trial and error looking at disassembly and testing the offsets, I might have something wrong, but everything works so far for me in some test demos that include switching between players and thirdperson.

@ImDini
Copy link

ImDini commented Jul 18, 2021

I'd be willing to test with few demos

@ImDini ImDini mentioned this pull request Jul 19, 2021
@rtldg
Copy link
Author

rtldg commented Jul 20, 2021

@ImDini Here's a build since you asked but you'll still need to drop ffmpeg.exe in the folder. crashfort said they'd look into putting it in a version of svr (instead of just a quick release with it merged) so should probably wait for that mainly.
svr-with-csgo-vel-overlay-30e3680.zip

@crashfort
Copy link
Owner

crashfort commented Oct 10, 2021

Done in SVR 35. Thank you.

@crashfort crashfort closed this Oct 10, 2021
@tslashd tslashd mentioned this pull request Nov 29, 2021
@ImDini
Copy link

ImDini commented Dec 13, 2021

@ImDini Here's a build since you asked but you'll still need to drop ffmpeg.exe in the folder. crashfort said they'd look into putting it in a version of svr (instead of just a quick release with it merged) so should probably wait for that mainly. svr-with-csgo-vel-overlay-30e3680.zip

This version sadly doesn't work any longer since CSGO update (and latest releases don't have velocity working)

@dPexxIAM
Copy link

@ImDini Here's a build since you asked but you'll still need to drop ffmpeg.exe in the folder. crashfort said they'd look into putting it in a version of svr (instead of just a quick release with it merged) so should probably wait for that mainly. svr-with-csgo-vel-overlay-30e3680.zip

This version now crashes with error code

Resolving component 'config-001-view-render' with signature 'void(__fastcall*)(void* p, void* edx, void* rect)' and type 1
Component could not be created
Component 'view-render' could not be resolved
Could not initialize game. Terminating
Initialization failure

I guess we need updated signatures for this function call, but i have no idea where to find that.

@rtldg
Copy link
Author

rtldg commented Dec 14, 2021

I made a PR at #57 which has the relevant code from this so the newer SVR releases can show the velocity overlay for spectating players whenever/if it's merged.

@ImDini
Copy link

ImDini commented Dec 15, 2021

I made a PR at #57 which has the relevant code from this so the newer SVR releases can show the velocity overlay for spectating players whenever/if it's merged.

Would you be willing to update your older version of SVR so it's fixed on latest CSGO? I always have issues with latest releases of SVR

@rtldg
Copy link
Author

rtldg commented Dec 15, 2021

Would you be willing to update your older version of SVR so it's fixed on latest CSGO? I always have issues with latest releases of SVR

Sorry, no. It might be as simple as updating game-config.json but it's not something I want to put time into

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants