Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed image resolution for familiar references #32

Closed
wants to merge 1 commit into from

Conversation

skrech
Copy link

@skrech skrech commented Aug 19, 2022

Fixes #31

@skrech
Copy link
Author

skrech commented Sep 26, 2022

Hey @crashvb, what do you think about this change. :)

@crashvb
Copy link
Owner

crashvb commented Sep 26, 2022

Sorry for the delay; changed jobs so my timing is a little off. LGTM at first glace, but I'd like to run it through some downstream tests on the RH side to make sure that behavior is limited to only DH.

@skrech
Copy link
Author

skrech commented Nov 10, 2022

Hey @crashvb, gentle reminder to see if you manage to test these changes. :)

@crashvb
Copy link
Owner

crashvb commented Nov 10, 2022

@kyatite Can you test this downstream, please?

@crashvb crashvb self-assigned this Nov 10, 2022
@crashvb crashvb added bug Something isn't working enhancement New feature or request labels Nov 10, 2022
@stale
Copy link

stale bot commented Jan 9, 2023

This discussion has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 9, 2023
@stale
Copy link

stale bot commented Jan 16, 2023

This discussion has been closed due to inactivity.

@stale stale bot closed this Jan 16, 2023
@crashvb crashvb reopened this Jan 25, 2023
@stale stale bot removed the stale label Jan 25, 2023
@crashvb
Copy link
Owner

crashvb commented Jan 25, 2023

Superseded; see comments in #31

@crashvb crashvb closed this Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve image name with library prefix only when it's from DockerHub
2 participants