Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add py.typed #33

Merged
merged 1 commit into from
Dec 7, 2022
Merged

Add py.typed #33

merged 1 commit into from
Dec 7, 2022

Conversation

rhelmot
Copy link
Contributor

@rhelmot rhelmot commented Dec 7, 2022

This enables static type checking of consumer applications by using drca's inline type annotations.

@crashvb crashvb self-requested a review December 7, 2022 22:47
@crashvb crashvb self-assigned this Dec 7, 2022
@crashvb crashvb merged commit 5900ad5 into crashvb:main Dec 7, 2022
@crashvb
Copy link
Owner

crashvb commented Dec 7, 2022

Merged and released in v0.2.8, but I don't see the file added to the package. I'm going to have to read up on PEP-561 ...

@rhelmot
Copy link
Contributor Author

rhelmot commented Dec 7, 2022

Oh, shoot, if you're doing sdists you'll have to add the file to MANIFEST.in. package_data is only for wheels I think?

@crashvb
Copy link
Owner

crashvb commented Dec 8, 2022

Yep, that appears to be the way that works; good call. I also tried different variants of setup.cfg and looked back at other packages that embed data using package_data via setup.py, and they too only appear to be embedding into the wheel ... oops ...

Fixed and pushed in v0.2.9. Thank you for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants