Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invisible text on Konsole solarized light theme #41

Closed
goertzenator opened this issue Jan 1, 2018 · 3 comments
Closed

invisible text on Konsole solarized light theme #41

goertzenator opened this issue Jan 1, 2018 · 3 comments

Comments

@goertzenator
Copy link
Contributor

Some of the text output is invisible when using KDE Konsole with the solarized light theme. Having not used this program in some time, I initially thought cargo release was just hanging, but eventually figured out what was going on.

I haven't had this issue with any other programs, so perhaps the use of color should be revisited for this program.

image

@swsnr
Copy link

swsnr commented Jan 14, 2018

The same issue occurs in iTerm2 with Solarized Light.

cargo release prints the confirmation prompt in white color which is the same as the background colour in Konsole and iTerm2 implementations of Solarized Light.

If you switch to Solarized Dark, or select the area with the mouse, the text becomes visible.

@sunng87 Can you perhaps add a flag to disable colours for this prompt? Or use bold text instead of a specific colour?

sunng87 added a commit that referenced this issue Jan 15, 2018
Signed-off-by: Ning Sun <sunng@about.me>
@sunng87
Copy link
Collaborator

sunng87 commented Jan 15, 2018

Hi @goertzenator @lunaryorn , this should be fixed in beta4, in which I removed color White for the prompt text.

@swsnr
Copy link

swsnr commented Jan 15, 2018

@sunng87 Many thanks for the quick fix ❤️

@sunng87 sunng87 closed this as completed Jan 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants