fix(workspace): Wait for publish to finish #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunng87
reviewed
Nov 16, 2019
A while back, publishing a crate was made asynchronous from `cargo-publish`. The problem is if we publish a crate at the bottom of the dependency tree and then publish something that depends on it, that can fail the test-compile because the crate is unavailable. We didn't run into problems before because usually we did enough stuff between publish calls that it was done by the time we hit the next crate. Switching to batch-processing broke this so now we are explicitly waiting until the crate version is listed as published. Fixes crate-ci#182
sunng87
approved these changes
Nov 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while back, publishing a crate was made asynchronous from
cargo-publish. The problem is if we publish a crate at the bottom ofthe dependency tree and then publish something that depends on it, that
can fail the test-compile because the crate is unavailable. We didn't
run into problems before because usually we did enough stuff between
publish calls that it was done by the time we hit the next crate.
Switching to batch-processing broke this so now we are explicitly
waiting until the crate version is listed as published.
Fixes #182