fix(config)!: Disable dev-version by default #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of just allowing overriding of defaults, this also allows overriding of the config. BREAKING CHANGE: This did cause a change in precedence between `--sign` and `--sign-commit` / `--sign-tag`.
Having a post-release version bump can help communicate that someone is using `main` but has the problems of - It isn't actually the next version because the next version is unknown - It hurts users of the crate being released because they can't as easily `[patch]` the depedency with `main` to test out the new release Fixes crate-ci#82 BREAKING CHANGE: We've changed the default `dev-version = false` to `dev-version = true`.
bors bot
added a commit
to nix-rust/nix
that referenced
this pull request
Dec 18, 2021
1609: Fix warning when running cargo release r=rtzoeller a=rtzoeller
`cargo release` is returning the following warning: `WARN cargo_release::config] Negative config values are deprecated ('no_', 'disable_')`.
The root cause is `cargo-release` changing its behavior to default to not bumping the version: crate-ci/cargo-release#340. Remove the `no-dev-version flag` from release.toml to match.
Co-authored-by: Ryan Zoeller <rtzoeller@rtzoeller.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a post-release version bump can help communicate that someone is
using
mainbut has the problems ofeasily
[patch]the depedency withmainto test out the new releaseAs part of implementing this, I decided to switch from negative config values to positive ones
falsecan be niceI still kept the negatives in the CLI but also added positive versions, though hidden. This also allows overriding the config file.