Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(index): Don't talk to crates.io when using alt registry #735

Merged
merged 2 commits into from
Dec 27, 2023

Conversation

epage
Copy link
Collaborator

@epage epage commented Dec 27, 2023

Ideally we'd find the proper registry and talk to it but that takes a
lot more work to support.
Until then, we'll just act like the registry has no packages in it and
put in some specific hacks to support it.

This should be less brittle than our previous approach which just hoped
we sprinkled config.registr().is_none() in the right places.

Fixes #732

Ideally we'd find the proper registry and talk to it but that takes a
lot more work to support.
Until then, we'll just act like the registry has no packages in it and
put in some specific hacks to support it.

This should be less brittle than our previous approach which just hoped
we sprinkled `config.registr().is_none()` in the right places.


Fixes crate-ci#732
@epage epage merged commit 33795ed into crate-ci:master Dec 27, 2023
13 checks passed
@epage epage deleted the registry branch December 27, 2023 22:01
@bobrik
Copy link

bobrik commented Dec 28, 2023

I have publish = ["myregistry"] in my Cargo.toml and cargo-release still fails with this change.

Printing pkg.config.registry() reveals that it's None. Is it expected that I also need to pass --registry=myregistry?

@epage
Copy link
Collaborator Author

epage commented Dec 28, 2023

At this time; yes. Feel free to open an issue about respecting public = [names]. Not many of us have experience with alternative registries to know how all of these pieces fit together.

@bobrik
Copy link

bobrik commented Dec 28, 2023

Sure, I made #736.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crates.io index is checked even for --no-push to a private registry
2 participants