refactor(parser): Switch to bstr for line splitting

crate-ci · Jul 14, 2019 · 4ce7303 · 4ce7303
1 parent 9a3aef7
commit 4ce7303
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 58 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -27,12 +27,12 @@ ignore = "0.4"
 phf = { version = "0.7", features = ["unicase"] }
 regex = "1.0"
 lazy_static = "1.2.0"
-grep-searcher = "0.1"
 serde = "1.0"
 serde_derive = "1.0"
 serde_json = "1.0"
 itertools = "0.8"
 unicase = "1.1"
+bstr = "0.2"
 
 [dev-dependencies]
 assert_fs = "0.10"

diff --git a/src/lib.rs b/src/lib.rs
@@ -12,6 +12,8 @@ pub use crate::dict::*;
 use std::fs::File;
 use std::io::Read;
 
+use bstr::ByteSlice;
+
 pub fn process_file(
     path: &std::path::Path,
     dictionary: &Dictionary,
@@ -20,7 +22,8 @@ pub fn process_file(
 ) -> Result<(), failure::Error> {
     let mut buffer = Vec::new();
     File::open(path)?.read_to_end(&mut buffer)?;
-    for (line_idx, line) in grep_searcher::LineIter::new(b'\n', &buffer).enumerate() {
+
+    for (line_idx, line) in buffer.lines().enumerate() {
         let line_num = line_idx + 1;
         for ident in tokens::Identifier::parse(line) {
             if !ignore_hex && is_hex(ident.token()) {