Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect and ignore base64 encoded data #287

Closed
Skylion007 opened this issue Jun 15, 2021 · 1 comment
Closed

Detect and ignore base64 encoded data #287

Skylion007 opened this issue Jun 15, 2021 · 1 comment
Labels
enhancement Improve the expected

Comments

@Skylion007
Copy link

When trying to run typos on iPython notebooks like Google Colabs, it destroys all the base64 data inside of the notebook [banana.jpg]. Base64 is not necessarily a spelling error: For example running it in this folder mangles the notebooks: https://github.com/facebookresearch/habitat-sim/tree/master/examples/tutorials/colabs .

@epage epage added the enhancement Improve the expected label Jun 15, 2021
@epage epage changed the title BUG: Typos destroys ipython notebooks (base64 encodings) Detect and ignore base64 encoded data Jun 15, 2021
@epage
Copy link
Collaborator

epage commented Jun 15, 2021

Short term, I'd recommend

[type.jupyter]
check-file = false

See https://github.com/crate-ci/typos#false-positives

Longer term, we are discussing in #270 for ignoring hashes, and base64. Since that issue is titled for hashes, I'll leave this one open to track also addressing base64. Keeping them focused can help in if we don't address them at the same time.

@epage epage closed this as completed in 2a1e6ca Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve the expected
Projects
None yet
Development

No branches or pull requests

2 participants