feat(pre-commit): add binary based install #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For no additional build dependencies (besides Python >= 3.6), and faster install. The setup.py here is a copy of the one at https://github.com/shellcheck-py/shellcheck-py with changes kept at the bare minimum for future diffability. We don't support checksumming at least yet, because there's no access to them from cargo-release at the moment. Closes #285
epage
reviewed
Jun 28, 2021
|
And ignore the CI failures. One is a CI bug (shouldn't be failing build, just the job) and the other seemed to have been broken by a new Rust release. |
|
I should add a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For no additional build dependencies (besides Python >= 3.6), and faster
install.
The setup.py here is a copy of the one at
https://github.com/shellcheck-py/shellcheck-py with changes kept at the
bare minimum for future diffability.
We don't support checksumming at least yet, because there's no access to
them from cargo-release at the moment.
Closes #285