Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: Improve "Testcontainers for Python" implementation #57

Open
8 tasks
amotl opened this issue Oct 10, 2023 · 2 comments
Open
8 tasks

Testing: Improve "Testcontainers for Python" implementation #57

amotl opened this issue Oct 10, 2023 · 2 comments

Comments

@amotl
Copy link
Contributor

amotl commented Oct 10, 2023

Introduction

We are aiming to provide canonical "Testcontainers" implementations for Java and Python, per testcontainers-java and testcontainers-python.

About

At the spots enumerated below, we added the first version of a corresponding Python implementation, originally conceived at daq-tools/lorrystream#47.

Backlog

@amotl amotl changed the title Improve "Testcontainers for Python" implementation for CrateDB Testing: Improve "Testcontainers for Python" implementation Oct 10, 2023
@amotl
Copy link
Contributor Author

amotl commented Nov 23, 2023

Together with @pilosus, we have been able to bring in a few advancements to the "Testcontainers for Python" adapter implementations we are running here. Thanks!

@amotl
Copy link
Contributor Author

amotl commented Nov 23, 2023

It will be nice to have a modern test layer which forms a cluster, for both Java and Python.

If we would like to contribute the existing implementation early, I think it makes sense to think about another detail of "naming things" on this matter.

If we would like to have CrateDBContainer to be the one and only to be responsible to spin up single-node instances, while there will be future implementations permitting to run whole clusters, I think it can make sense to reflect that into a naming scheme like CrateDBSingleNodeContainer vs. CrateDBMultiNodeContainer.

However, while writing that down, it could also be a dual-class machinery of the existing CrateDBContainer and an additional CrateDBClusterManager, which, well, manages the former.

It is probably too early to think about this topic without getting hands-on with it, mainly starting by researching how others might be doing similar things like managing a fleet of containers on behalf of a single convenience entrypoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant