fix: add forwardRef back to button component

cratebind · Jan 10, 2022 · a00f0a0 · a00f0a0
1 parent 375db48
commit a00f0a0
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 3 deletions.
diff --git a/cypress/components/Text.spec.tsx b/cypress/components/Text.spec.tsx
@@ -5,5 +5,23 @@ import { Text } from '../../src/Text';
 it('renders children as text', () => {
   const text = 'Text';
   mount(<Text id="target">{text}</Text>);
-  cy.get('#target').contains(text);
+  cy.get('p').contains(text);
+});
+
+it('passes styles to <p> element', () => {
+  const styles = {
+    color: 'red',
+    fontSize: '20px',
+  };
+
+  mount(<Text {...styles}>Text</Text>);
+
+  cy.get('p').should('have.css', 'color', 'rgb(255, 0, 0)');
+  cy.get('p').should('have.css', 'font-size', '20px');
+});
+
+it('renders different elements with "as" prop', () => {
+  mount(<Text as="h1">Text</Text>);
+
+  cy.get('h1').contains('Text');
 });
diff --git a/src/Button/index.tsx b/src/Button/index.tsx
@@ -75,7 +75,7 @@ export interface ButtonProps extends MinervaProps, PseudoBoxProps {
 //   }: ButtonProps,
 //   forwardedRef
 // ) {
-export const Button = function Button(
+export const Button = React.forwardRef(function Button(
   {
     children,
     disabled = false,
@@ -146,7 +146,7 @@ export const Button = function Button(
       {isLoading ? <Spinner /> : children}
     </Box>
   );
-} as ForwardRefComponent<'button', ButtonProps>;
+}) as ForwardRefComponent<'button', ButtonProps>;
 
 export default Button;