Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing/Adding translations in components, vue, controller #1020

Closed
wants to merge 23 commits into from

Conversation

agencetwogether
Copy link

@agencetwogether agencetwogether commented Aug 23, 2022

Hello, I'm falling in love about this project. 😊
And I would like to contribute by helping in particular to correct untranslated, missing or hard-coded elements.

That's why I made some commits to do this.
I hope these commits can help community and that they will be integrated to the next release.

To working properly, I started from version 6.0.6, I tried to correct each local language file in which keys were missing (compared to the English reference version).
For each translation carried out, all the language files have been updated.

Of course, each added key will have to be translated into the language concerned

Thanks again for this crazy project

More details about commits :

  • Months below lines in Dashboard and Customers views are now in language defined by locale inside config/app.php
  • Data table is now localized
  • Search bar placeholder and Confirm password label (customers views in admin) are fixed to use translation
  • Add missing keys in ko.json and pt-br.json
  • Add translation for This year and Previous year in drop down above Charts
  • Add news keys in locales files according missing translations for next commits (below this one)
  • Customer portal menu is working now with translations (due to missing option to choose a language in customer settings portal, to be able to have portal in locale, you have to set this on in ressources/scripts/Crater.js)
  • Tooltip to Copy in clipboard works with translations
  • Sign up and get token button working now with translations
  • Limit by and Frequency dropdowns in Recurring invoices are now translated
  • Amount Due below Invoice dropdown in Payment section is now translated
  • Report type dropdown in Reports section is now translated
  • Add translation to BaseFileUploader
  • Add translation to BaseMultiselect
  • Add translation to BaseDatePicker
  • Add news keys in locales files according missing translations for next commits (below this one)
  • Translations everything about Estimates (Admin and Customer portal) using locale
  • Translations everything about Invoices (Admin and Customer portal) using locale
  • Translations everything about Recurring invoices (Admin and Customer portal) using locale
  • Translation for Type dropdown in Note Modal
  • Remove some hardcoded texts by replacing them to locale
  • Improve stats in Dashboards (Admin and Customer portal) with singular/plural (see locale files)
  • Remove some hardcoded texts for Payments by replacing them to locale

@agencetwogether agencetwogether changed the title Fix translations in Charts with locale defined in config/app.php Fixing/Adding translations in components, vue, controller Aug 23, 2022
@caiodigioia
Copy link

That's awesome! How can I test the changes on my website?

@agencetwogether
Copy link
Author

That's awesome! How can I test the changes on my website?

Until these fixes are incorporated in a future version, you can add the changes to your files if you wish, and republish the assets with yarn build command

@mohitpanjwani
Copy link
Contributor

This PR is really well done.

Thanks for the contribution @agencetwogether

So far it's looking really good but I still need to test this a bit more before merging it. I'll update here by weekend 👍

@azaricstefan
Copy link
Contributor

@agencetwogether huge thanks for this effort!!!!

@azaricstefan
Copy link
Contributor

azaricstefan commented Sep 18, 2022

@mohitpanjwani , @agencetwogether
I tested the translations. This is still a bug #1041.

This file footer could also be translated: "resources/views/vendor/mail/text/message.blade.php"

@thalesog
Copy link

thalesog commented Mar 2, 2023

Bump!
Can we get this merged?

@azaricstefan
Copy link
Contributor

@mohitpanjwani @agencetwogether bump ++

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants