skip otherwise failing tests with PHP 7.3 and PostgreSQL

craue · Aug 30, 2023 · 00e4ed1 · 00e4ed1
1 parent ce0881a
commit 00e4ed1
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/Tests/PhotoUploadFlowTest.php b/Tests/PhotoUploadFlowTest.php
@@ -16,6 +16,14 @@ class PhotoUploadFlowTest extends IntegrationTestCase {
 
 	const IMAGE = '/Fixtures/blue-pixel.png';
 
+	protected function setUp() : void {
+		if (\version_compare(\PHP_VERSION, '7.4', '<') && ($_ENV['DB_FLAVOR'] ?? '') === 'postgresql') {
+			$this->markTestSkipped('Would fail because SerializableFile::__serialize is only supported as of PHP 7.4.');
+		}
+
+		parent::setUp();
+	}
+
 	public function testPhotoUpload() {
 		$image = __DIR__ . self::IMAGE;
 

diff --git a/Tests/Storage/DataManagerIntegrationTest.php b/Tests/Storage/DataManagerIntegrationTest.php
@@ -26,6 +26,10 @@ class DataManagerIntegrationTest extends IntegrationTestCase {
 	 * Ensure that a file uploaded within a flow is saved and restored correctly.
 	 */
 	public function testSaveLoad_file() : void {
+		if (\version_compare(\PHP_VERSION, '7.4', '<') && ($_ENV['DB_FLAVOR'] ?? '') === 'postgresql') {
+			$this->markTestSkipped('Would fail because SerializableFile::__serialize is only supported as of PHP 7.4.');
+		}
+
 		$session = new Session(new MockArraySessionStorage());
 		$session->setId('12345');