Fix bug of setting skipped class to step links

[simohammedhttp]

No description provided.

[craue]

Could you explain the bug in more detail, maybe with an example? I don't see what's wrong with the current implementation. Is it an edge case?

[simohammedhttp]

I noticed that when I load the form for the first time all the skippable steps are set with craue_formflow_skipped_step which is weird.
Let's assume we have a flow of two steps: Step1 and Step2, Step1 contains usedProducts property (collection of checkboxes), Step2 must be skipped if usedProducts != 'ProductX' (the product being studied in survey).
When I load the survey, Step2 is marked skipped, even I haven't responded to Step1 yet.

[craue]

The current implementation allows marking succeeding steps as skipped, which is correct. So make sure that your skip function always evaluates to the expected result. Maybe something like this for step 2:

'skip' => function($estimatedCurrentStepNumber, FormFlowInterface $flow) {
    return $estimatedCurrentStepNumber > 1 && !$flow->getFormData()->hasUsedProduct('ProductX');
}

[coveralls]

Coverage decreased (-19.22%) to 80.18% when pulling 05cdd1e on simohammedhttp:master into ffbf596 on craue:master.

[simohammedhttp]

Mmm..
It sounds interesting, I'll give it a try.

[craue]

@simohammedhttp: Is it ok for you to close this PR?

[simohammedhttp]

Yes, I think the actual implementation is quite good.

2015-06-10 13:40 GMT+01:00 Christian Raue notifications@github.com:

@simohammedhttp https://github.com/simohammedhttp: Is it ok for you to
close this PR?

—
Reply to this email directly or view it on GitHub
#182 (comment)
.