button label override #200
Conversation
… is with button classes
| button_finish: craue_formflow_button_label_finish | default('button.finish'), | ||
| button_next: craue_formflow_button_label_next | default('button.next'), | ||
| button_back: craue_formflow_button_label_back | default('button.back'), | ||
| button_reset: craue_formflow_button_label_back | default('button.reset') |
There was a problem hiding this comment.
I guess this is meant to be craue_formflow_button_label_reset.
|
Could you avoid changing the indentation? I'm using tabs instead of spaces. |
… is with button classes
…ndle into add-button-labels
|
Updated with upstream/master and fixed the indentation/codestyle |
| @@ -5,7 +5,14 @@ | |||
| Thus, all buttons are defined in reverse order and will be reversed again via CSS. | |||
| See http://stackoverflow.com/questions/1963245/multiple-submit-buttons-specifying-default-button | |||
| #} | |||
|
|
|||
| {%- | |||
| set craue_label = { | |||
|
Could you also add documentation and tests for this, similar to what has been done in #126? |
|
@pculka, do you still want to work on this? |
|
Hi, yes, but I'm in holidays atm, will resume work once back. Want to finish this |
|
@pculka, I absolutely don't begrudge you a long vacation, but are there any news? 😏 |
|
ooon it, sorry, was quite busy in work lately |
|
hmmm no idea how to integrate the tests properly, any idea how to see if the tests did cover the code? No idea how to test .twig |
|
@pculka, see #200 (comment) 😏 |
|
/ping @pculka |
add the possibility to override button labels in the same logic as it is with button classes