Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional persistence of step data on flow back transition #248

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Optional persistence of step data on flow back transition #248

wants to merge 10 commits into from

Conversation

linxlad
Copy link

@linxlad linxlad commented Jun 3, 2016

Added optional class property and logic for step data persistence if the flow is transitioned backwards. If persistence on backwards transition is enabled and the current request transition is 'back' then persist the current step data to storage.

Added optional class property and logic for step data persistance if …
0a0ff6e 
…the flow is transitioned backwards. If persistence on backwards transition is enabled and the current request transition is 'back' then persist the current step data to storage.
@linxlad linxlad mentioned this pull request Jun 3, 2016
Closed
@coveralls
Copy link

coveralls commented Jun 3, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-1.1%) to 98.626% when pulling 12f3046 on linxlad:master into 551482e on craue:master.

@linxlad
Update FormFlow.php
3ef1d60 
Updated comment to actually match what it does.
@linxlad
Update FormFlow.php
0e3e148 
Updated comment to match others.
@linxlad
Copy link
Author

linxlad commented Jun 3, 2016

Please see gif recording of this PR in action:
http://cl.ly/gMHA

@coveralls
Copy link

coveralls commented Jun 3, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-2.1%) to 97.651% when pulling 3ef1d60 on linxlad:master into 551482e on craue:master.

@Filoz
Copy link

Filoz commented Jun 3, 2016 •
edited
Loading

Hi,
great! :)
I think you should also add a "set" and "is" method for the persistOnBackTransition variable, like revalidatePreviousSteps has setRevalidatePreviousSteps and isRevalidatePreviousSteps

@coveralls
Copy link

coveralls commented Jun 3, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-2.1%) to 97.651% when pulling 0e3e148 on linxlad:master into 551482e on craue:master.

@coveralls
Copy link

coveralls commented Jun 3, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-2.1%) to 97.651% when pulling 0e3e148 on linxlad:master into 551482e on craue:master.

@linxlad
Update FormFlow.php
b819d27 
Added setter and is methods for persistOnBackTransition.
@linxlad
Copy link
Author

linxlad commented Jun 3, 2016

@Filoz Thanks for the suggestion. I have added those methods :)

@coveralls
Copy link

coveralls commented Jun 3, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-2.1%) to 97.651% when pulling 0e3e148 on linxlad:master into 551482e on craue:master.

@linxlad
Update FormFlow.php
066357d 
Actually don't need to set the form data as it is just getting the form name.
@coveralls
Copy link

coveralls commented Jun 3, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-1.9%) to 97.847% when pulling b819d27 on linxlad:master into 551482e on craue:master.

@coveralls
Copy link

coveralls commented Jun 3, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-2.3%) to 97.407% when pulling 066357d on linxlad:master into 551482e on craue:master.

@coveralls
Copy link

coveralls commented Jun 3, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-2.3%) to 97.407% when pulling 066357d on linxlad:master into 551482e on craue:master.

@coveralls
Copy link

coveralls commented Jun 3, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-2.3%) to 97.407% when pulling 066357d on linxlad:master into 551482e on craue:master.

@coveralls
Copy link

coveralls commented Jun 3, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-2.3%) to 97.407% when pulling 066357d on linxlad:master into 551482e on craue:master.

@linxlad
Copy link
Author

linxlad commented Jun 6, 2016 •
edited
Loading

@craue Does this look ok? :)

@linxlad
Copy link
Author

linxlad commented Dec 6, 2016

@craue Been nearly 6 months now. Is this git abandoned?

@craue
Copy link
Owner

craue commented Dec 9, 2016

Is this git abandoned?

@linxlad, as you can see from the commit history, it is not. 😏

I'm still trying to implement transitions (#67), which would be a more flexible approach than this one. Furthermore, tests are completely missing here.

@TerjeBr
Copy link

TerjeBr commented Dec 16, 2016

Please, can we have this pull request?
It is a very useful feature I also want.

@linxlad
Copy link
Author

linxlad commented Mar 7, 2017

@craue This one fits with what you currently code and I am unsure of how #67 would solve the persistence of data on stepping back?

@craue
Copy link
Owner

craue commented Aug 7, 2017

Still, there are no tests covering this functionality, so I cannot merge it yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@linxlad @coveralls @Filoz @craue @TerjeBr