fix file upload in collections

[jwaschkau]

No description provided.

[coveralls]

Coverage remained the same at 99.751% when pulling 2211e79 on BlazingSun:master into aaca075 on craue:master.

[craue]

It would be nice to have a test proving that there's an issue at all, as well as proving that this change fixes it, also to avoid future regressions.

[craue]

Could you set up such a failing scenario, e.g. by forking the demo bundle and modifying the photo upload flow?

[jwaschkau]

@craue Yes, i will see what i can do.

[InTimesIT]

Hi, I just met this issue.
Thank you for your solution, I've override the method in my form flow. :)

[craue]

@jwaschkau, any progress?

[syeikhanugrah]

This should be merged.

[craue]

A test is still needed.

[craue]

What exactly is the issue here? Could you explain?

[craue]

I can't fix something that's not proven to be broken.

[jwaschkau]

Hi @craue,
i won't be able to provide a testcase, because i am not developing PHP anymore.
In some cases the file upload was not working. I think currentStepData was filled with default values and array_merge just appends uploads as a list and does not overwrite existing values.

[craue]

@jwaschkau, alright. Never mind then. 😏

@syeikhanugrah, could you give some more details on how to reproduce the issue?

[syeikhanugrah]

@craue I've created repo for this issue: https://github.com/syeikhanugrah/CraueFormFlowBundle276, and try to replace with this: https://gist.github.com/syeikhanugrah/906406e47ec3d763d1fd7d270919e77b.

Because array_merge_recursive doesnt overwrite existing value, but appended to the new ArrayCollection.

[blump]

@syeikhanugrah 's solution is correct.

Is it possible to correct this problem?

[craue]

Unfortunately, the repo @syeikhanugrah mentions is unavailable. We got no test or code exposing the problem and I'm still unable to see the issue. Please enlighten me, @blump.