Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EffectiveTldFinderTests failing after merge pull request #100 #103

Closed
aecio opened this issue Oct 7, 2015 · 2 comments
Closed

EffectiveTldFinderTests failing after merge pull request #100 #103

aecio opened this issue Oct 7, 2015 · 2 comments
Assignees

Comments

@aecio
Copy link
Contributor

aecio commented Oct 7, 2015

Although maven build is finished successfully, the two tests cases in class EffectiveTldFinderTest seems to be failing after pull request #100. Can anyone reproduce this?

End of Report:

Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.141 sec

Results :

Failed tests:   testWildcardEtld(crawlercommons.url.EffectiveTldFinderTest)
  testExceptionEtld(crawlercommons.url.EffectiveTldFinderTest)

Tests run: 92, Failures: 2, Errors: 0, Skipped: 0

[ERROR] There are test failures.

Please refer to ~/workspace/crawler-commons-clean/target/surefire-reports for the individual test results.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 15.965 s
[INFO] Finished at: 2015-10-07T00:13:01-04:00
[INFO] Final Memory: 27M/794M
[INFO] ------------------------------------------------------------------------
@jnioche
Copy link
Contributor

jnioche commented Oct 7, 2015

thanks @aecio I'll investigate this

jnioche added a commit that referenced this issue Oct 7, 2015
@jnioche
Copy link
Contributor

jnioche commented Oct 7, 2015

OK, fixed in [b7ccc8d]
This was due to changes to the UK section of the reference list. Thanks for reporting it

@jnioche jnioche closed this as completed Oct 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants