Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename package crawlercommons.url #107

Closed
jnioche opened this issue Nov 10, 2015 · 3 comments
Closed

Rename package crawlercommons.url #107

jnioche opened this issue Nov 10, 2015 · 3 comments
Labels
question
Milestone
crawler-commons-0.7

Comments

@jnioche
Copy link
Contributor

jnioche commented Nov 10, 2015

That code is specific to domains. I find the name 'crawlercommons.url' quite vague, especially if we add support for URL filtering elsewhere. What about renaming it to 'crawlercommons.domains' ?
@jnioche
Copy link
Contributor Author

jnioche commented Dec 2, 2015

@crawler-commons/owners any thoughts?

@kkrugler
Copy link
Contributor

kkrugler commented Dec 2, 2015

+1 from me.

@lewismc
Copy link
Member

lewismc commented Dec 2, 2015

+1

On Wednesday, December 2, 2015, Ken Krugler notifications@github.com
wrote:

+1 from me.

—
Reply to this email directly or view it on GitHub
#107 (comment)
.

Lewis

jnioche added a commit to DigitalPebble/crawler-commons that referenced this issue Dec 3, 2015
@jnioche
Rename package crawlercommons.url crawler-commons#107
347f50c
@jnioche jnioche mentioned this issue Dec 3, 2015
Closed
@lewismc lewismc added this to the crawler-commons-0.7 milestone Sep 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
crawler-commons-0.7
Development

No branches or pull requests
3 participants
@kkrugler @jnioche @lewismc