Allow to include/exclude private domains / effective TLDs without re-initialization, fixes #185 #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sebastian-nagel
commented
Nov 5, 2017
sebastian-nagel
commented
- add optional flag excludePrivate to getAssignedDomain(...) / getEffectiveTLD(...)
- remove methods which exclude private eTLD during initialization
sebastian-nagel
force-pushed
the
cc-185-effective-tld-finder-private-domains
branch
from
6c2c80c
to
eb5498b
Compare
kkrugler
reviewed
Nov 5, 2017
| if (getInstance().domains.containsKey(hostname)) { | ||
| return getInstance().domains.get(hostname); | ||
| EffectiveTLD foundTld = getInstance().domains.get(hostname); | ||
| if (!excludePrivate || !foundTld.isPrivate) { |
There was a problem hiding this comment.
Very minor nit, but !(excludePrivate && foundTld.isPrivate) is clearer to me.
kkrugler
approved these changes
Nov 5, 2017
…initialization, fixes crawler-commons#185 - add optional flag excludePrivate to getAssignedDomain(...) / getEffectiveTLD(...) - remove methods which exclude private eTLD during initialization
sebastian-nagel
force-pushed
the
cc-185-effective-tld-finder-private-domains
branch
from
eb5498b
to
ca0fdd4
Compare
for PaidLevelDomain detection - adapt unit tests: 'de.com' is a private suffix, consequently 'xxx.de.com' isn't a PaidLevelDomain - rebase on master, apply code format
sebastian-nagel
force-pushed
the
cc-185-effective-tld-finder-private-domains
branch
from
ca0fdd4
to
f598af8
Compare
sebastian-nagel
deleted the
cc-185-effective-tld-finder-private-domains
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.