Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to include/exclude private domains / effective TLDs without re-initialization, fixes #185 #186

Merged
merged 2 commits into from
Dec 1, 2017
Merged

Allow to include/exclude private domains / effective TLDs without re-initialization, fixes #185 #186

merged 2 commits into from
Dec 1, 2017

Commits on Nov 6, 2017

  1. Allow to include/exclude private domains / effective TLDs without re-… 

    …initialization, fixes crawler-commons#185

- add optional flag excludePrivate to getAssignedDomain(...) / getEffectiveTLD(...)
- remove methods which exclude private eTLD during initialization
    @sebastian-nagel
    sebastian-nagel committed Nov 6, 2017
    Configuration menu
    Copy the full SHA
    cda1bde View commit details
    Browse the repository at this point in the history

  2. - address TODO of crawler-commons#184: do not use of private suffixes 

      for PaidLevelDomain detection
- adapt unit tests: 'de.com' is a private suffix,
  consequently 'xxx.de.com' isn't a PaidLevelDomain
- rebase on master, apply code format
    @sebastian-nagel
    sebastian-nagel committed Nov 6, 2017
    Configuration menu
    Copy the full SHA
    f598af8 View commit details
    Browse the repository at this point in the history