Upgraded to Junit v5.5 #250
Conversation
Bringing the last 4 years into my fork
Updated the annotations and assertions accordingly
|
It passes when using Intellij Idea. It didn't fail before my submit |
|
Now all tests pass on Intellij Idea and also on commandline mvn Please check out my pull request :-) |
Fixing a styling issue I caused about 4 years ago Details can be found here: #82
There was a problem hiding this comment.
Thanks, @Chaiavi! Code builds and tests pass! Could you
- run
mvn java-formatter:formatto format the source code (see my comment how to preserve line breaks) - squash the commits
or let me know if I shall do it. Thanks!
|
|
||
| sb.append("url = \"").append(url).append("\", lastMod = ").append((getLastModified() == null) ? "null" : SiteMap.W3C_FULLDATE_FORMATTER_UTC.format(getLastModified().toInstant())) | ||
| .append(", type = ").append(getType()).append(", processed = ").append(isProcessed()).append(", urlListSize = ").append(urlList.size()); | ||
| StringBuilder sb = new StringBuilder() |
There was a problem hiding this comment.
Formatting is done by mvn java-formatter:format which would again put all the lines together. I agree (my personal preference) that every append in its own line is more readable. If // is added to every line the formatter will keep it.
There was a problem hiding this comment.
Thanks, nice hack, I will try it then run the mvn formatter command and check to see the results.
| @@ -1,5 +1,5 @@ | |||
| /** | |||
| * Copyright 2016 Crawler-Commons | |||
| * Copyright 2019 Crawler-Commons | |||
There was a problem hiding this comment.
I don't know whether we any policies regarding the year of the copyright notice. Afaik, the notices haven't been changed since added in 2016 (0775bb2).
There was a problem hiding this comment.
I will revert the year changes,
If we decide to change the copyright year, we will do it in a separate commit dedicated to it (and done yearly)
Thanks again @sebastian-nagel
There was a problem hiding this comment.
Ok, let's wait for comments or open a separate issue for it. And yes, if we decide to do it it should be done yearly (alternatively, in preparation for a release) and for all source files.
Fixing a styling issue I caused about 4 years ago Details can be found here: #82
|
Ok, this commit fixes @sebastian-nagel code review It passes the tests, and the formatter |
|
Oops, I just wanted to squash the commits but it also merged them into master, but I think it is a good commit Should I revert? |
|
Hi @Chaiavi, everything looks fine. Thanks! Reverting or anything which requires a forced push is rarely a good idea in an open source repository as it leads to errors for users which already fetched the affected commits. |
|
Thankyou @sebastian-nagel I will be wiser next squash and commit |
Updated the annotations and assertions accordingly
This should close #249