Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google Sitemap PageMap extensions #388

Closed
josepowera opened this issue Oct 19, 2022 · 1 comment
Closed

Google Sitemap PageMap extensions #388

josepowera opened this issue Oct 19, 2022 · 1 comment
Assignees
@sebastian-nagel
Labels
sitemaps
Milestone
1.5

Comments

@josepowera
Copy link

Can't find any reference to extension with support for PageMap - is https://support.google.com/programmable-search/answer/1628213?hl=en#zippy=%2Cadd-pagemap-data-directly-to-your-html-page%2Cadd-pagemap-data-to-a-sitemap

supported in Sitemap parser?
@sebastian-nagel
Copy link
Contributor

Hi @josepowera, page maps are currently not supported by the sitemap parser and are simply ignored. Is this a feature request?

@sebastian-nagel sebastian-nagel self-assigned this Apr 24, 2023
@sebastian-nagel sebastian-nagel added this to the 1.4 milestone May 11, 2023
sebastian-nagel added a commit to sebastian-nagel/crawler-commons that referenced this issue Jun 9, 2023
@sebastian-nagel
[Sitemaps] Google Sitemap PageMap extensions, implements crawler-comm…
b1ed5c1 
…ons#388

TODO!!
@sebastian-nagel sebastian-nagel modified the milestones: 1.4, 1.5 Jul 12, 2023
sebastian-nagel added a commit to sebastian-nagel/crawler-commons that referenced this issue Oct 24, 2023
@sebastian-nagel
[Sitemaps] Google Sitemap PageMap extensions, implements crawler-comm…
95d9f27 
…ons#388
sebastian-nagel added a commit to sebastian-nagel/crawler-commons that referenced this issue Oct 24, 2023
@sebastian-nagel
[Sitemaps] Google Sitemap PageMap extensions, implements crawler-comm…
d27fbd0 
…ons#388
sebastian-nagel added a commit to sebastian-nagel/crawler-commons that referenced this issue Oct 24, 2023
@sebastian-nagel
[Sitemaps] Google Sitemap PageMap extensions, implements crawler-comm…
67ff87c 
…ons#388
sebastian-nagel added a commit to sebastian-nagel/crawler-commons that referenced this issue Oct 24, 2023
@sebastian-nagel
[Sitemaps] Google Sitemap PageMap extensions, implements crawler-comm…
0e97d04 
…ons#388
@sebastian-nagel sebastian-nagel mentioned this issue Oct 24, 2023
Merged
sebastian-nagel added a commit to sebastian-nagel/crawler-commons that referenced this issue Oct 24, 2023
@sebastian-nagel
[Sitemaps] Google Sitemap PageMap extensions, implements crawler-comm…
aee49e1 
…ons#388

- address review comments
- prevent from NPEs when adding data from inner XML elements
  when outer XML elements (PageMap, DataObject) are missing
sebastian-nagel added a commit to sebastian-nagel/crawler-commons that referenced this issue Oct 24, 2023
@sebastian-nagel
[Sitemaps] Google Sitemap PageMap extensions, implements crawler-comm…
835fafe 
…ons#388

- address review comments
  - move parts of the PageMap.asMap() to PageMapDataObject.asMap()
  - add missing license header
sebastian-nagel added a commit to sebastian-nagel/crawler-commons that referenced this issue Oct 28, 2023
@sebastian-nagel
[Sitemaps] Google Sitemap PageMap extensions, implements crawler-comm…
2a4e32c 
…ons#388
jnioche pushed a commit that referenced this issue Oct 28, 2023
@sebastian-nagel
[Sitemaps] Google Sitemap PageMap extensions, implements #388 (#442)
54576e8
@jnioche jnioche closed this as completed Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebastian-nagel sebastian-nagel

Labels
sitemaps
Projects
None yet
Milestone
1.5
Development

No branches or pull requests
3 participants
@jnioche @sebastian-nagel @josepowera