[Sitemaps] SiteMap should contain a list of SitemapUrls instead of a table of them

[GoogleCodeExporter]

A SiteMap object should contain a collection of SiteMapUrls.

Currently it contains a TABLE where the key is the url and the value is the 
SiteMapUrl object.

The key is always siteMapUrl.getUrl().


This is just confusing and not needed.
I have checked and nobody uses this table's key anywhere... - even the getter 
returns only the TABLE.values().

We should change the table to a set or a list (much less confusing) and 
implement equals & hashcode in SiteMapUrl

Original issue reported on code.google.com by avrah...@gmail.com on 26 Oct 2014 at 12:33

• Blocking: [Sitemaps] Upgrade Valid / Legal / Strict SitemapUrls #60

[GoogleCodeExporter]

The same fix should be implied to SiteMapIndex

Original comment by avrah...@gmail.com on 26 Oct 2014 at 12:44

[GoogleCodeExporter]

Done.

Including a patch

Original comment by avrah...@gmail.com on 25 Dec 2014 at 11:46

Attachments:

• Issue_57.patch

[GoogleCodeExporter]

Original comment by avrah...@gmail.com on 25 Dec 2014 at 11:50

• Now blocking: [Sitemaps] Upgrade Valid / Legal / Strict SitemapUrls #60

[GoogleCodeExporter]

Avi I am + 1 for this patch. It cleans up the codebase by removing unnecessary 
method calls wrapped in method calls. Please commit.

Original comment by lewis.mc...@gmail.com on 7 Jan 2015 at 8:44

[GoogleCodeExporter]

Committed at r156

Original comment by avrah...@gmail.com on 12 Jan 2015 at 10:54

• Changed state: Fixed

[GoogleCodeExporter]

Original comment by avrah...@gmail.com on 13 Jan 2015 at 11:20

• Added labels: Type-Enhancement
• Removed labels: Type-Defect