Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sitemaps] Upgrade Valid / Legal / Strict SitemapUrls #60

Closed
GoogleCodeExporter opened this issue Apr 9, 2015 · 8 comments
Closed

[Sitemaps] Upgrade Valid / Legal / Strict SitemapUrls #60

GoogleCodeExporter opened this issue Apr 9, 2015 · 8 comments

Comments

@GoogleCodeExporter
Copy link

SitemapUrls can be not valid when they are referenced in a sitemap which it's 
directory is on a completely different path than the referenced SitemapUrl.

All as indicated here:
http://www.sitemaps.org/protocol.html#location


In order to clarify the validity aspect we need to upgrade the following
1. Add a little more explanations as javadocs and as logs
2. Rename "Legal" (I think only one occurrence) to "valid" (in the parser)
3. Add to the Sitemap class a new method to get all *valid* SitemapUrls
4. When dropping a URL due to invalidity a log should be shown, a URL shouldn't 
be dropped quietly.

Original issue reported on code.google.com by avrah...@gmail.com on 9 Nov 2014 at 2:10

@GoogleCodeExporter
Copy link
Author

Original comment by avrah...@gmail.com on 25 Dec 2014 at 11:49

@GoogleCodeExporter
Copy link
Author

Attaching a patch

Original comment by avrah...@gmail.com on 13 Jan 2015 at 11:21

  • Changed state: Started
  • Added labels: Type-Enhancement
  • Removed labels: Type-Defect

Attachments:

@Chaiavi Chaiavi added this to the crawler-commons 0.6 milestone Apr 13, 2015
@jnioche
Copy link
Contributor

jnioche commented May 8, 2015

Ok this one seems to be the only one flagged for 0.6

@Chaiavi could you do a Pull Request for it? Don't forget you can apply the formatting with mvn java-formatter:format see #76; this will make it a lot easier to review it.

@Chaiavi
Copy link
Member

Chaiavi commented May 8, 2015

ok, will do.

Will take me a couple of days to get to it though...

On Fri, May 8, 2015 at 6:07 PM, Julien Nioche notifications@github.com
wrote:

Ok this one seems to be the only one flagged for 0.6

@Chaiavi https://github.com/Chaiavi could you do a Pull Request for it?
Don't forget you can apply the formatting with mvn java-formatter:format
see #76 #76;
this will make it a lot easier to review it.


Reply to this email directly or view it on GitHub
#60 (comment)
.

@jnioche jnioche removed this from the crawler-commons 0.6 milestone May 22, 2015
@jnioche
Copy link
Contributor

jnioche commented May 22, 2015

Removed from 0.6 milestone, we can do this later

@Chaiavi
Copy link
Member

Chaiavi commented Aug 25, 2015

This one fixes also #90

@lewismc
Copy link
Member

lewismc commented Aug 25, 2015

Can we do a pull request with this one?

@Chaiavi
Copy link
Member

Chaiavi commented Aug 26, 2015

The pull request exists here:
#82

On Tue, Aug 25, 2015 at 11:32 PM, Lewis John McGibbney <
notifications@github.com> wrote:

Can we do a pull request with this one?


Reply to this email directly or view it on GitHub
#60 (comment)
.

@lewismc lewismc added this to the crawler-commons-0.7 milestone Sep 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants