Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maven-java-formatter-plugin #76

Merged
merged 3 commits into from
May 6, 2015
Merged

maven-java-formatter-plugin #76

merged 3 commits into from
May 6, 2015

Conversation

jnioche
Copy link
Contributor

@jnioche jnioche commented Apr 30, 2015

Fixes #49

The command mvn java-formatter:format will apply the formatting to the code using the Eclipse formatting provided.

The latter can be imported directly in Eclipse and there seems to be plugins for other editors, however the point here is that the formatting will be done regardless of which editor is used.

We can discuss / improve / modify the actual formatting choices but at least we'll have a mechanism for enforcing it.

Please review, thanks!

@jnioche jnioche added this to the crawler-commons 0.6 milestone Apr 30, 2015
@jnioche
Copy link
Contributor Author

jnioche commented May 5, 2015

@crawler-commons/owners - any objections to committing this?

@kkrugler
Copy link
Contributor

kkrugler commented May 5, 2015

Hi Julien - looks good, thanks!

Two things I noticed...

  1. We now have doc/eclipse-formatter.properties and doc/eclipse-formatter.xml. I think you can get rid of the .properties version, as that was from when we were using ant (and the ant-eclipse task needed a .properties file to create the Eclipse project)
  2. The eclipse-formatter.xml file you provided is for a 1.5-compliant project. E.g. compiler.source=1.5, etc. We're at 1.6 now, and I think if you switch to a 1.6 project, there will be extra settings. So I think using a 1.6-compliant formatting file would be a better starting point.

@jnioche
Copy link
Contributor Author

jnioche commented May 6, 2015

Thanks Ken

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proper code styling template and mechanism to enforce it
2 participants