Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifying parsing methods of SiteMapParser so they are protected rath… #124

Merged

Conversation

michaellavelle
Copy link
Contributor

…er than private. This allows for custom implementations of SiteMapParser, for example to handle extensions such as Google News sitemaps

Copy link
Contributor

@jnioche jnioche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Any other comments from @crawler-commons/owners ?

@jnioche jnioche added this to the crawler-commons-0.7 milestone Sep 19, 2016
@jnioche jnioche merged commit 145ff5c into crawler-commons:master Sep 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants