Upgrade to JDK 1.8 #126
Upgrade to JDK 1.8 #126
Conversation
|
For some reason the TravisCI config is not being picked up. |
| @@ -1,5 +1,9 @@ | |||
| language: java | |||
|
|
|||
| script: | |||
| - jdk_switcher use oraclejdk8 | |||
There was a problem hiding this comment.
Have you tried
jdk:
- oraclejdk8
| @@ -1,5 +1,9 @@ | |||
| language: java | |||
|
|
|||
| script: | |||
| - jdk_switcher use oraclejdk8 | |||
| - mvn install javadoc:aggregate | |||
There was a problem hiding this comment.
This defines the targets to run... we always wish to build the Javadoc target as this lets us know if the Javadoc is JDK8 compliant.
There was a problem hiding this comment.
ok, thanks. I assumed the javadoc was checked by Travis
| @@ -74,13 +74,13 @@ public static EffectiveTldFinder getInstance() { | |||
| return instance; | |||
| } | |||
|
|
|||
| public boolean initialize(InputStream effective_tld_data_stream) { | |||
There was a problem hiding this comment.
Are _ not allowed in Java8?
There was a problem hiding this comment.
Yes... but they are flagged as warn's for the Javac. It is not Java convention.
|
Did you run |
Actually no I did not.. I will do that right now. |
|
@jnioche can you please review again at your earlier opportunity. Thank you. |
|
Merged, thanks @lewismc |
and changed presentation of issue number
This issue addresses #125