[Robots.txt] Path analyse bug with url-decode if allow/disallow path contains escaped wild-card characters #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…contains escaped wild-card characters - properly percent-encode allow/disallow paths and URL paths during rule matching - decode characters where necessary - add unit tests
…contains escaped wild-card characters - fix path matching for paths containing `*` or `$`
rzo1
approved these changes
May 14, 2023
|
Thanks, @rzo1! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(fixes #195)
*or$: percent-encoded in rules because of the special meaning. See also Special characters * and $ not matched in URI google/robotstxt#57 for clarification about the correct behavior.