Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
CrawlTaskConsumer
to always close the crawler, in a finally block.Change
WebDriverBackedEmbeddedBrowser
to close/quit the browser in a different thread than the one being called to avoid interruptions, which could prevent the WebDriver (e.g. chromedriver, geckodriver) from being terminated, leading to process leaks.Quit the browser directly instead of using WebDriverManager when it does not contain any as the WebDriver might not have been created through it (e.g. when using custom
Provider<EmbeddedBrowser>
).Downstream change: zaproxy#20.
Sample exception when failed to quit the WebDriver because of the interrupt:
which prevents both WebDriver and browser to quit.