Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Scripts.java #616

Merged
merged 1 commit into from May 9, 2023
Merged

Update Scripts.java #616

merged 1 commit into from May 9, 2023

Conversation

666asd
Copy link
Contributor

@666asd 666asd commented Apr 25, 2023

Change computedStyleMap to getComputedStyle

@666asd
Update Scripts.java
e819b6c 
Change computedStyleMap to getComputedStyle
@666asd 666asd mentioned this pull request Apr 25, 2023
Closed
@666asd
Copy link
Contributor Author

666asd commented Apr 25, 2023

fix #615

@thc202
Copy link
Contributor

thc202 commented Apr 25, 2023

Would be great to have tests as well.

@amesbah amesbah requested a review from yrahulkr April 25, 2023 15:27
@yrahulkr yrahulkr merged commit 9ea0f78 into crawljax:master May 9, 2023
5 of 7 checks passed
yrahulkr
yrahulkr reviewed May 9, 2023
View reviewed changes
Copy link
Contributor

@yrahulkr yrahulkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked the code and it is good. However, for some reason the tests keep failing for edge driver on GitHub CI. I was able to succesfully run the tests on my machine.

@thc202
Copy link
Contributor

thc202 commented May 9, 2023

CI was fixed with #618.

@666asd 666asd deleted the fix-#615 branch May 10, 2023 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yrahulkr yrahulkr yrahulkr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@666asd @thc202 @yrahulkr