Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure new browsers have page loaded #622

Merged
merged 1 commit into from Jun 1, 2023

Conversation

thc202
Copy link
Contributor

@thc202 thc202 commented May 12, 2023

It could happen that a new browser was open to crawl a new state but the page was not accessed beforehand leading to, e.g.:

Eventable element is not valid: Unable to locate element: /X/Y/Z[1]

and causing the crawler to miss states.

@thc202
Copy link
Contributor Author

thc202 commented May 12, 2023

Maybe there's a better way to address this, I thought on calling reset but this seems to be fine to do.

@sonatype-lift
Copy link
Contributor

sonatype-lift bot commented May 12, 2023

🛠 Lift Auto-fix

Some of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1

# Download the patch
curl https://lift.sonatype.com/api/patch/github.com/crawljax/crawljax/622.diff -o lift-autofixes.diff

# Apply the patch with git
git apply lift-autofixes.diff

# Review the changes
git diff

Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command:

curl https://lift.sonatype.com/api/patch/github.com/crawljax/crawljax/622.diff | git apply

Once you're satisfied, commit and push your changes in your project.

Footnotes

  1. You can preview the patch by opening the patch URL in the browser.

It could happen that a new browser was open to crawl a new state but the
page was not accessed beforehand leading to, e.g.:
```
Eventable element is not valid: Unable to locate element: /X/Y/Z[1]
```
and causing the crawler to miss states.

Signed-off-by: thc202 <thc202@gmail.com>
@amesbah amesbah merged commit cf0c261 into crawljax:master Jun 1, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants