Add command parser before create system call #144 #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ces would not open on mac. Also changed in linux which would have the same effect. And changed system calls to receive a list of args to keep it open to extension in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
May I suggest to create a command parser aware of spaces to avoid errors when filenames containing spaces would not open on mac. As well of being able to concatenate multiple commands if needed in the future.
Change mac implementation to use the parser
Also changed in linux which would have the same effect.
And changed system calls to receive a list of args to keep it open to extension in the future.
A minor fix on the comment of the linux implementation.