Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon in dark Theme is not visible #59

Closed
amarradi opened this issue Jul 22, 2022 · 12 comments
Closed

Icon in dark Theme is not visible #59

amarradi opened this issue Jul 22, 2022 · 12 comments
Assignees
Labels

Comments

@amarradi
Copy link
Contributor

In dark mode 2 icons are not visible

See the screenshot. You have to copy the icons in the -night folder

Screenshot_20220722-100006.png

Screenshot_20220722-100256.png

@CrazyMarvin
Copy link
Contributor

Thanks for noticing this. 👍
Are you available to fix this (and maybe #60)?

@amarradi
Copy link
Contributor Author

amarradi commented Jul 22, 2022 via email

@amarradi
Copy link
Contributor Author

i tried to checkout an new branch but i need the permission, that i can push to you and you can merge it.

@CrazyMarvin
Copy link
Contributor

i tried to checkout an new branch but i need the permission, that i can push to you and you can merge it.

To which branch did you try to push? The trunk (master branch) is protected but the default branch development should work.

@CrazyMarvin
Copy link
Contributor

For a pull request (PR) you have to make the changes in your own copy/fork and from there you can open a PR to this repository. Check this for more info.

@amarradi
Copy link
Contributor Author

amarradi commented Jul 25, 2022

[marcus@thinkpad VacationDays]$ git push origin development
remote: Permission to Crazy-Marvin/VacationDays.git denied to amarradi.
fatal: konnte nicht auf 'https://github.com/Crazy-Marvin/VacationDays/' zugreifen: The requested URL returned error: 403

The Errormessage

@CrazyMarvin
Copy link
Contributor

OK, I will give you the permission for now.
But the usual process would be to do a fork (it would appear in your account like https://github.com/amarradi/VacationDays) and a PR afterwards.

@CrazyMarvin
Copy link
Contributor

You may accept the invitation and try to push again. 👌

@amarradi
Copy link
Contributor Author

It is ready you can remove the write permissions again

@CrazyMarvin
Copy link
Contributor

Thank you very much for your help! 👍

@amarradi
Copy link
Contributor Author

When will you release a final version?

@CrazyMarvin
Copy link
Contributor

When will you release a final version?

This weekend I suppose. I would like to include the fix for #47 too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants