Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to dockerhub or the respective hub in notification mail #40

Closed
logopk opened this issue Feb 21, 2020 · 16 comments · Fixed by #92
Closed

Link to dockerhub or the respective hub in notification mail #40

logopk opened this issue Feb 21, 2020 · 16 comments · Fixed by #92
Milestone

Comments

@logopk
Copy link

logopk commented Feb 21, 2020

Hi,

would it be possible to add a link to the tag page of docker hub (maybe other repos too).

I don't know if the url can always be deferred from the info like "docker.io/library/mariadb:latest"
-> https://hub.docker.com/_/mariadb?tab=tags

Thanks!

Peter

@crazy-max
Copy link
Owner

Hi @logopk,

would it be possible to add a link to the tag page of docker hub (maybe other repos too).

Yes that's possible.

I don't know if the url can always be deferred from the info like "docker.io/library/mariadb:latest"
-> https://hub.docker.com/_/mariadb?tab=tags

I'm not aware of a discovery service on registries to retrieve this kind of info so I think we should rely on a static dictionary to handle this.

@crazy-max crazy-max added this to the v4 milestone Jun 3, 2020
crazy-max added a commit that referenced this issue Jun 8, 2020
@crazy-max crazy-max linked a pull request Jun 8, 2020 that will close this issue
crazy-max added a commit that referenced this issue Jun 9, 2020
@crazy-max
Copy link
Owner

crazy-max commented Jun 17, 2020

@logopk Links to hubs are available through release 4.0.0-beta.3 if you want to try out.

@logopk
Copy link
Author

logopk commented Jun 17, 2020

Hi,
would like to but the change in config is a bit of a problem.
I just transitioned to version 3 with multiple instances for my different docker hosts.
But 4 refuses to come up:

diun_1     | Wed, 17 Jun 2020 13:51:46 CEST INF Starting Diun version=4.0.0-beta.3
diun_1     | Wed, 17 Jun 2020 13:51:46 CEST FTL Cannot load configuration error="Key: 'Config.Providers' Error:Field validation for 'Providers' failed on the 'required' tag"

Do you have a default config to start with? docker-compose preferrably?
Thanks

@logopk
Copy link
Author

logopk commented Jun 17, 2020

OK, I transitioned to ENV-VARS and now it works. Let me wait for the first notification.

@crazy-max
Copy link
Owner

crazy-max commented Jun 17, 2020

@logopk

OK, I transitioned to ENV-VARS and now it works.

Yes env vars is the way-to-go if you use a provider like docker, swarm or k8s ;)

Let me wait for the first notification.

👍

@logopk
Copy link
Author

logopk commented Jun 18, 2020

Apparently smth. missing:

image

@crazy-max
Copy link
Owner

@logopk I don't think so, the link is here:

image

What did you expect?

@logopk
Copy link
Author

logopk commented Jun 18, 2020

🤦🏼‍♂️ Perfect! That's what I was hoping for! Thanks.

I got confused from this:

It's an extra Link on the bottom...

@crazy-max
Copy link
Owner

@logopk Yeah indeed for Slack I cannot combine a link and code

@logopk
Copy link
Author

logopk commented Jun 18, 2020

I see one issue - but this is due to the new one-provider solution - the notification mail has always the same provider-name: docker (or file).

It used to have the unique provider name.

Would it be possible to add the unique source of the Mails?

@crazy-max
Copy link
Owner

@logopk docker and swarm providers are unique so it will stay as it is. But concerning the file provider we can for example set the filename as the provider in the notification. What do you think?

@logopk
Copy link
Author

logopk commented Jun 18, 2020

Hmm. I have separated my three remote docker providers into 3 containers. Now all send mails as "docker". Before they all had unique (host-)names.
Some images run on all hosts, some only on one of them. Maybe I will have to improve my memory...

@crazy-max
Copy link
Owner

crazy-max commented Jun 18, 2020

@logopk Ok thanks for the tips. I think I will prepend the hostname to the provider.

@logopk
Copy link
Author

logopk commented Jun 18, 2020

That sounds like a good idea. Thanks.

@crazy-max
Copy link
Owner

crazy-max commented Jun 22, 2020

Available through 4.0.0 release. See https://crazy-max.github.io/diun/changelog/#400-20200622.

@logopk
Copy link
Author

logopk commented Jun 24, 2020

@crazy-max: this works perfectly with #102
Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants