Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable communication with Nomad using Task API over a unix socket #1049

Merged
merged 1 commit into from Dec 15, 2023

Conversation

IamTheFij
Copy link
Contributor

This patch updates the Nomad client to 1.7 bringing the ability to use a Unix Socket to communicate with the Nomad API.

@IamTheFij IamTheFij marked this pull request as draft December 13, 2023 01:04
@IamTheFij IamTheFij marked this pull request as ready for review December 13, 2023 22:37
@IamTheFij
Copy link
Contributor Author

The failure is the same that is on master right now. I've got another PR #1050 out to resolve that issue. This should be safe to merge, or it can be rebased when #1050 is merged so that the checks can all be green.

go.mod Outdated Show resolved Hide resolved
Copy link
Owner

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should enough with #1056 if you want to rebase and bring these changes. I have updated google.golang.org/grpc and github.com/containers/image. 🙏

@IamTheFij IamTheFij force-pushed the nomad-1.7 branch 2 times, most recently from 9623245 to 633f40c Compare December 15, 2023 20:56
@ViViDboarder
Copy link

Ok. Cut it down and rebased.

@crazy-max crazy-max merged commit 118f2e9 into crazy-max:master Dec 15, 2023
63 checks passed
@IamTheFij
Copy link
Contributor Author

@crazy-max Is it possible to get another release tagged so this feature can go live?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants