Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rTorrent: Schedule torrent session save as background task #358

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

stickz
Copy link
Contributor

@stickz stickz commented Jun 8, 2024

fixes #281

This commit schedules the session save when a new download is inserted. The benefit if we can thread it as a background task. This avoids disruptions during startup and increases overall speed. The unique hash of the torrent is used as the schedule handle, to prevent accidently overwriting the task. It runs once and immediately.

@stickz stickz requested a review from crazy-max as a code owner June 8, 2024 16:33
@stickz stickz force-pushed the patch-7 branch 2 times, most recently from 329c41c to 1adfbe6 Compare June 8, 2024 16:39
@stickz
Copy link
Contributor Author

stickz commented Jun 8, 2024

@crazy-max The pull request test feature is broken. I tested this change, it works as intended.

Addresses crazy-max#281

This commit schedules the session save when a new download is inserted. The benefit if we can thread it as a background task. This avoids disruptions during startup and increases overall speed. The unique hash of the torrent is used as the schedule handle, to prevent accidently overwriting the task. It runs once and immediately.
@crazy-max
Copy link
Owner

rebased to take #360

@crazy-max crazy-max merged commit 2f8f463 into crazy-max:master Jun 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rutorrent UI is not showing up but "loading"
2 participants