Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label rename doesn't work #120

Closed
jvalkeal opened this issue Dec 15, 2020 · 0 comments · Fixed by #121
Closed

Label rename doesn't work #120

jvalkeal opened this issue Dec 15, 2020 · 0 comments · Fixed by #121

Comments

@jvalkeal
Copy link
Contributor

I simply get an error Cannot rename "test" label: Not Found.

current_name: label.from_name,

Looking above call, shouldn't parameters be like in an api docs:

await octokit.request('PATCH /repos/{owner}/{repo}/labels/{name}', {
  owner: 'octocat',
  repo: 'hello-world',
  name: 'name',
  new_name: 'new_name'
})
jvalkeal added a commit to jvalkeal/ghaction-github-labeler that referenced this issue Dec 16, 2020
- Now using correct api fields, `current_name` vs `new_name`.
- Fixes crazy-max#120
jvalkeal added a commit to jvalkeal/ghaction-github-labeler that referenced this issue Dec 16, 2020
- Now using correct api fields, `current_name` vs `new_name`.
- Fixes crazy-max#120
jvalkeal added a commit to jvalkeal/ghaction-github-labeler that referenced this issue Dec 16, 2020
- Now using correct api fields, `current_name` vs `new_name`.
- Fixes crazy-max#120
crazy-max pushed a commit that referenced this issue Dec 16, 2020
- Now using correct api fields, `current_name` vs `new_name`.
- Fixes #120
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant