Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keeping history even with keep_history: false #27

Closed
pyrrhicPachyderm opened this issue Nov 19, 2019 · 3 comments
Closed

Keeping history even with keep_history: false #27

pyrrhicPachyderm opened this issue Nov 19, 2019 · 3 comments
Labels

Comments

@pyrrhicPachyderm
Copy link

I may be misinterpretting what keep_history: false is supposed to do, but it doesn't seem to be doing it, even when I set is explicitly.

It is my understanding that it's supposed to get rid of any old commits on the target branch, so that the target branch only ever has one commit at a time. This is the desired behaviour for me, as my compiled material is quite large and will quickly take up a lot of space.

But my target branch is accumulating commits each time the action runs, as you can see here and here. This is my configuration (identical for both repos):

if: success()
uses: crazy-max/ghaction-github-pages@v1
with:
  target_branch: gh-pages
  build_dir: website
  keep_history: false
env:
  GITHUB_PAT: ${{ secrets.GITHUB_PAT }}```
@pyrrhicPachyderm pyrrhicPachyderm changed the title Keeping history even with keep_history: false Keeping history even with keep_history: false Nov 19, 2019
@crazy-max
Copy link
Owner

Hi @pyrrhicPachyderm,

You absolutely right, good catch!
Will be solved asap, keep you in touch!

crazy-max added a commit that referenced this issue Nov 19, 2019
@crazy-max
Copy link
Owner

crazy-max commented Nov 19, 2019

@pyrrhicPachyderm Should be fixed with latest release (v1, v1.2 or v1.2.4 tag)

@pyrrhicPachyderm
Copy link
Author

Awesome! Works perfectly! Thanks very much for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants