Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the Windows OS #514

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

jaimecbernardo
Copy link

This pull request adds support for running react-native-splash-screen with react-native-windows.
It also updates the example to the latest react-native 0.63 and adds an Windows example.

@jaimecbernardo
Copy link
Author

Hi @crazycodeboy ,

Since opening this PR, I've made the following additional changes:

  • fix a bug where the splash screen would be hidden but still capturing input.
  • add automated tests running through the example.
  • add a button in the example to show the splash screen again.
  • add a github workflow to run the automated tests on pull requests if github actions are turned on.

The PR is now ready for review.
Thank you 😄

@achipa
Copy link

achipa commented Mar 29, 2021

This would be really, really great to have - is there anything preventing this PR from going in? Happy to help ironing out any kinks if that's what's holding this up.

@kpete2017
Copy link

Is there any estimated time for 0.64 support? Seems like it's currently not compatible.

@jaimecbernardo
Copy link
Author

Hi @kpete2017 ,
Thanks for reporting this. I've added a commit with a fix for 0.64.
Please give it a try and let me know.

@Victor0814gui
Copy link

Any updates here?👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants