Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README for SplashScreen.show() #562

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

saamerm
Copy link

@saamerm saamerm commented Feb 1, 2022

SplashScreen.show(this, R.style.SplashScreenTheme, true);

* Updated README for the new function definition for show
```
SplashScreen.show(this, R.style.SplashScreenTheme, true);
```
@saamerm
Copy link
Author

saamerm commented Feb 11, 2022

@crazycodeboy I think this will help a lot of developers

Copy link

@puneetsngh puneetsngh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can describe the default and updated behaviour for true/false

@Adnan-Bacic
Copy link

Adnan-Bacic commented May 17, 2022

i agree with updating the docs so explain the difference.

i just tested on a project and the only difference for me is the android navigation buttons disappears when true is passed, but is shown when false is passed. i think false looks much better so i believe that one is preferred. and before this parameter was added, it was not fullscreen.

if you set it to true, it will happen like this:

  1. user sees the navigation bar on their phone
  2. user presses your app, and the navigation buttons are hidden while splash screen is showing
  3. splash screen is hidden, navigation bar is shown again

i have a mostly white splash screen image and this is how it looks like for me.

true:
true

false:
false

i dont think setting fullscreen makes much sense on android, as most people will probably have the navigation buttons, as opposed to swipe navigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants