Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch for PHP >= 8.4 #324

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Patch for PHP >= 8.4 #324

merged 2 commits into from
Feb 5, 2024

Conversation

petk
Copy link
Contributor

@petk petk commented Jan 30, 2024

What does this PR do?

Hello, I've removed the FIBER_ASM_ARCH in favor of the FIBER_ASM_ABI in PHP 8.4 Windows build system. This fixes the build for PHP >= 8.4 if this patch is still needed here. Thanks.

Checklist before merging

If your PR involves the changes mentioned below and completed the action, please tick the corresponding option.
If a modification is not involved, please skip it directly.

  • If it's a extension or dependency update, make sure adding related extensions in src/global/test-extensions.php.
  • If you changed the behavior of static-php-cli, add docs in static-php/static-php-cli-docs .
  • If you updated config/xxxx.json content, run bin/spc dev:sort-config xxx.

@petk
Patch for PHP >= 8.4
b20f3dc 
FIBER_ASSEMBLER and FIBER_ASM_ARCH Makefile variables in Windows build
system PHP 8.4 have been removed in favor of the PHP_ASSEMBLER and
FIBER_ASM_ABI.
@crazywhalecc crazywhalecc added bug Something isn't working kind/php-src Issues related to php source os/windows Things only for Windows labels Jan 30, 2024
crazywhalecc
crazywhalecc reviewed Feb 5, 2024
View reviewed changes
Copy link
Owner

@crazywhalecc crazywhalecc left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! BTW I'm not sure if this patch will work perfectly, could you provide some test scripts? It’s not a big problem if you don’t. There is no official version of 8.4 yet.

src/SPC/builder/windows/WindowsBuilder.php Outdated Show resolved Hide resolved
@petk
Copy link
Contributor Author

petk commented Feb 5, 2024

I'm not sure I'll be able to provide tests here. I would do if I'd know how... Yes, 8.4 is not available yet, it's a fix when the 8.4 will be out.

@crazywhalecc crazywhalecc merged commit a6f7b93 into crazywhalecc:main Feb 5, 2024
21 checks passed
@petk petk deleted the patch-windows branch February 5, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazywhalecc crazywhalecc crazywhalecc approved these changes

Assignees
No one assigned
Labels
bug Something isn't working kind/php-src Issues related to php source os/windows Things only for Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@petk @crazywhalecc